From 64c973060c227ad21150cb5a40e7ebe6601e6192 Mon Sep 17 00:00:00 2001
From: addshore <addshorewiki@gmail.com>
Date: Tue, 14 Nov 2017 10:40:23 +0000
Subject: [PATCH] Initial tests for Revision::getRevisionText

Bug: T180210
Change-Id: Idd5c1af7ecc336ba3f32b15fd8d5cb5bd19f649b
---
 tests/phpunit/includes/RevisionTest.php | 66 +++++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/tests/phpunit/includes/RevisionTest.php b/tests/phpunit/includes/RevisionTest.php
index 953c795e46..ca8ed2bcc1 100644
--- a/tests/phpunit/includes/RevisionTest.php
+++ b/tests/phpunit/includes/RevisionTest.php
@@ -466,4 +466,70 @@ class RevisionTest extends MediaWikiTestCase {
 		);
 	}
 
+	/**
+	 * @covers Revision::getRevisionText
+	 */
+	public function testGetRevisionText_returnsFalseWhenNoTextField() {
+		$this->assertFalse( Revision::getRevisionText( new stdClass() ) );
+	}
+
+	public function provideTestGetRevisionText_returnsDecompressedTextFieldWhenNotExternal() {
+		yield 'Just text' => [
+			(object)[ 'old_text' => 'SomeText' ],
+			'old_',
+			'SomeText'
+		];
+		// gzip string below generated with gzdeflate( 'AAAABBAAA' )
+		yield 'gzip text' => [
+			(object)[
+				'old_text' => "sttttr\002\022\000",
+				'old_flags' => 'gzip'
+			],
+			'old_',
+			'AAAABBAAA'
+		];
+		yield 'gzip text and different prefix' => [
+			(object)[
+				'jojo_text' => "sttttr\002\022\000",
+				'jojo_flags' => 'gzip'
+			],
+			'jojo_',
+			'AAAABBAAA'
+		];
+	}
+
+	/**
+	 * @dataProvider provideTestGetRevisionText_returnsDecompressedTextFieldWhenNotExternal
+	 * @covers Revision::getRevisionText
+	 */
+	public function testGetRevisionText_returnsDecompressedTextFieldWhenNotExternal(
+		$row,
+		$prefix,
+		$expected
+	) {
+		$this->assertSame( $expected, Revision::getRevisionText( $row, $prefix ) );
+	}
+
+	public function provideTestGetRevisionText_external_returnsFalseWhenNotEnoughUrlParts() {
+		yield 'Just some text' => [ 'someNonUrlText' ];
+		yield 'No second URL part' => [ 'someProtocol://' ];
+	}
+
+	/**
+	 * @dataProvider provideTestGetRevisionText_external_returnsFalseWhenNotEnoughUrlParts
+	 * @covers Revision::getRevisionText
+	 */
+	public function testGetRevisionText_external_returnsFalseWhenNotEnoughUrlParts(
+		$text
+	) {
+		$this->assertFalse(
+			Revision::getRevisionText(
+				(object)[
+					'old_text' => $text,
+					'old_flags' => 'external',
+				]
+			)
+		);
+	}
+
 }
-- 
2.20.1